feat!: add typo3 13 and 14 compatibility#22
Merged
Conversation
ervaude
requested changes
May 19, 2026
| $this->geocodingUrl .= '&key=' . $apiKey; | ||
| } | ||
| $this->maxRetries = (int)($geoCodingConfig['maxRetries'] ?? 0); | ||
| $this->maxRetries = (int) ($geoCodingConfig['maxRetries'] ?? 0); |
Contributor
There was a problem hiding this comment.
Where does this CGL rule come from? I dont think the core uses a whitespace after a cast.
Contributor
Author
There was a problem hiding this comment.
I've used the default php-cs-fixer config before. I've updated the config and executed php-cs-fixer again with TYPO3 specific config.
| 'createDirs' => '', | ||
| 'clearCacheOnLoad' => 0, | ||
| 'lockType' => '', | ||
| 'version' => '5.0.0', |
Contributor
There was a problem hiding this comment.
Please update the version here as well to a new major release
| }, | ||
| "require-dev": { | ||
| "typo3/coding-standards": "^0.8.0", | ||
| "ssch/typo3-rector": "^3.14", |
Contributor
There was a problem hiding this comment.
rector can be removed before we merge, right?
Contributor
Author
There was a problem hiding this comment.
I've removed the rector artifacts
| 'ClassAliasMap.php', | ||
| ], | ||
| ]) | ||
| ; |
Contributor
There was a problem hiding this comment.
I dont think we need this file in the repository, or do we?
Contributor
|
Thank you very much @lneugebauer ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19