Merged
Conversation
While registering a module like defined in README, the variable `$allowedModule` is set to true in submodules. This leads to a TypeError while array_merge(). To avoid this, a check is added if the referring submodule is loaded and then appends the submodule to the current `$finalModules` list. As `$moduleName` could be assigned to the main module name, the assignment at the beginning of the foreach was removed.
calien666
force-pushed
the
bugfix/submodule-registering
branch
from
7260c42 to
f567eea
Compare
bmack
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While registering a module like defined in README, the variable
$allowedModuleis set to true in submodules. This leads to a TypeError while array_merge().To avoid this, a check is added if the referring submodule is loaded and then appends the submodule to the current
$finalModuleslist.As
$moduleNamecould be assigned to the main module name, the assignment at the beginning of the foreach was removed.Fixes #11