fix: wrap bp.log methods to add dummy param and lazy stringify (#241)#242
Open
Codergoterrors wants to merge 1 commit intobThink-BGU:developfrom
Open
Conversation
…k-BGU#241) - Always append a dummy {} to log call args to prevent the single-array-param Java varargs misinterpretation issue - JSON.stringify object params only when the log level is active - Implemented as a JS wrapper in globalScopeInit.js, loaded at program scope initialization in BProgram.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241
Changes
globalScopeInit.js: Added a JS-level wrapper aroundbp.logthat:{}argument to every log call, preventingJava's varargs from misinterpreting a single array argument
JSON.stringifyto object params only when thelog level means the message will actually be printed
BProgram.java: ActivatedglobalScopeInit.jsby loading it duringsetup()right afterinitProgramScope()Testing
All 312 existing tests pass with 0 failures.