V2 enumerable internal #1057
Merged
V2 enumerable internal #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdotnet
force-pushed
the
v2-enumerable-internal
branch
2 times, most recently
from
60aeb63 to
e08e299
Compare
egil
previously approved these changes
May 4, 2023
linkdotnet
force-pushed
the
v2-enumerable-internal
branch
from
90ba024 to
8bc5b72
Compare
Good point - Added |
egil
approved these changes
May 5, 2023
egil
pushed a commit
that referenced
this pull request
Jun 10, 2023
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 2, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 3, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 6, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 6, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 7, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 11, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 13, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Mar 22, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
egil
pushed a commit
that referenced
this pull request
Apr 12, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
bUnitBot
pushed a commit
that referenced
this pull request
Apr 12, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Apr 19, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
bUnitBot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Jul 5, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
bUnitBot
pushed a commit
that referenced
this pull request
Jul 5, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
bUnitBot
pushed a commit
that referenced
this pull request
Jul 5, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
linkdotnet
added a commit
that referenced
this pull request
Jul 21, 2024
* refactor: Move EnumerableExtensions to usage and made it internal * refactor: Decrease visibility oof LoggerHelperExtensions * add: Documentation for migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the
EnumerableExtensionstobunit.weband made itinternal.There are two reasons: The main point being that this is a very common extension people are using - this might confuse users as well as conflict with other 3rd party libraries. I don't think bUnit should expose such functions.
The second reason: We are only using it in one place - I was thinking even having it only has a static local function instead of an extension.