Add overloads to InvokeAsync with a return value#1305
Add overloads to InvokeAsync with a return value#1305linkdotnet merged 3 commits intobUnit-dev:mainfrom
Conversation
|
@dotnet-policy-service agree |
|
Thanks for filing the PR @Jcparkyn ! |
|
Hey @Jcparkyn, if you have any documentation locally - just push it. The build server can take care of it. |
|
@Jcparkyn the docs should be totally fixed. |
|
Thanks @linkdotnet, just hadn't got around to writing it yet 😀. Do you think it's worth adding a full example, or just a sentence or two? I'd think that most people who need this feature would discover it from the existing docs - maybe not for the Edit: Another thing I never figured out is whether it's necessary (or best practice) to always await calls to |
781133a to
602f664
Compare
|
Added examples for both use cases, feel free to shorten it if you think they're not necessary. Also fixed a couple of incorrect line numbers in the docs. By the way, the docs build and run properly now, but I think the readme instructions need updating again to use the |
Yes, you are right, and we missed updating this again :D Edit: Updates the README.MD. Thnaks for the hint @Jcparkyn |
|
LGTM! Thanks for your efforts and time @Jcparkyn |
Closes #1296
Pull request description
Didn't include tests since there's essentially no logic changes here and the second overload already doesn't have any, but I can add them if wanted.
PR meta checklist
mainbranch for codeor targeted at
stablebranch for documentation that is live on bunit.dev.Code PR specific checklist