Fix/naming convention jsinterop

[yourilima]

Pull request description

PR meta checklist

• Pull request is targeting at DEV branch.
• Pull request is linked to all related issues, if any.
• I have read the CONTRIBUTING.md document.

Content checklist

• My code follows the code style of this project and AspNetCore coding guidelines.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• I have updated the appropriate sub section in the CHANGELOG.md.
• I have added, updated or removed tests to according to my changes.
  • All tests passed.

Change Checklist

• Rename Js to JS in Class, Method and File names
• Update documentation to reflect changes
• Update sample project to reflect changes in naming
• Move mocks to the TestDoubles folder

[yourilima]

For Issue #147 ( I cant seem to link Issue and PR)

Requires a bit of updating the docs.

I am in doubt if this requires an update in changelog. Probably due to changes to naming being a breaking change. Am i correct in this?

[yourilima]

I added a suggestion for a change in the readme.

[egil]

@yourilima yes, update the changelog in the "Unreleased beta-8" -> "Changed" section. Write something with same structure as the existing entry in that section.

[egil]

I know it is a bit tedious, but if you can also:

1. Update the /sample/tests/* tests that use JSInterop. You might have to update /sample/tests/SampleApp.Tests.csproj with project references to make it work locally, like /docs/sapmles/tests/xunit/bunit.docs.xunit.samples.csproj.
2. Update the /docs/site/docs/csharp-test-examples.md examples with the new syntax. That will make it easier for me when I have to write the https://bunit.egilhansen.com/docs/mocking/mocking-ijsruntime page.

[yourilima]

I know it is a bit tedious, but if you can also:

Don't worry about the tediousness :)

1. Update the /sample/tests/* tests that use JSInterop. You might have to update /sample/tests/SampleApp.Tests.csproj with project references to make it work locally, like /docs/sapmles/tests/xunit/bunit.docs.xunit.samples.csproj.

Should be done i ran tests locally and everything is running as it should. i suppose i should not update the projects dependency yet? or should i for the sake of the entire repo to be able to run and test? Then when you finalize beta-8 you'll update the reference to <PackageReference Include="bunit" Version="1.0.0-beta-8" />, or should i do that now prematurely?

2. Update the /docs/site/docs/csharp-test-examples.md examples with the new syntax. That will make it easier for me when I have to write the https://bunit.egilhansen.com/docs/mocking/mocking-ijsruntime page.

changed /docs/docs/csharp-test-examples.md as i presume you moved it in master

[egil]

Then when you finalize beta-8 you'll update the reference to <PackageReference Include="bunit" Version="1.0.0-beta-8" />, or should i do that now prematurely?

Leave it at 1.0.0-beta-8 now, thats fine.

changed /docs/docs/csharp-test-examples.md as i presume you moved it in master

Correct. I need to merge master into dev ASAP. Thanks for the heads up.

[egil]

This looks good. There is one more thing we should change now that we have these files open, its the namespace. A related issue @DarthPedro is working on (#146) is adding a new folder and namespace called TestDoubles, which is a more general term for mocks/stubs/fakes/dummys, so lets move MockJSRuntime into that as well. I.e.:

• Move all the JSMock code from /Mocking to /TestDoubles, in both the bunit.web and bunit.web.tests projects.
• Move all types that are in the Bunit.Mocking.JSInterop to be in the Bunit.TestDoubles.JSInterop namespace.

[egil]

Sorry, messed you up a little bit by merging main into dev, so the file in docs have moved.

[yourilima]

Don't worry I can fix it

[egil]

FYI: I have updated the dev branch with test-doubles as the name for the documentation section.

[egil]

Thanks @yourilima. It looks like all the boxes are ticked.

Do you consider this PR ready to be merged?

[yourilima]

Do you consider this PR ready to be merged?

I do. the checkbox for documentation only relates to /docs/site/docs/csharp-test-examples.md as you mentioned you'd update the docs separately. If that is correct I think it is ready.

This is a breaking change though. How will that be reflected in the changelog?

[yourilima]

The move to TestDoubles folder is a change to be attributed to @DarthPedro so i omitted that on the changelog for now.

[egil]

The move to TestDoubles folder is a change to be attributed to @DarthPedro so i omitted that on the changelog for now.

He is doing work on another PR which is attributed to him, so I think it is fine.

I will merge then. Thanks for your help. Let me know if you want to help out with other issues.