Add InvokeAsync overload#177
Add InvokeAsync overload#177egil merged 10 commits intobUnit-dev:devfrom JeroenBos:add_invoke_async_overload
Conversation
…ase, changed IRenderedFragment to enable converting method to extension methods
|
Hi @JeroenBos Thanks for this. Here is my initial comments:
|
Yes I question the need for them as well. They were more the result of trying to make a good PR.
I'm not clear on the design details for cut.SetParametersAndRender();
await cut.WaitForState();to await cut.SetParametersAndRenderAsync();which is even simpler for folks. |
…n.cs Co-authored-by: Jeroen Bos <jer123bos@gmail.com>
In most cases, calling The WaitFor* methods are only needed when something triggered from the test code causes the renderer to perform multiple renders asynchronously. See more here: https://bunit.egilhansen.com/docs/verification/async-assertion.html |
|
I just pushed an update to the docs. I think this is done. You? |
|
It's merged. Thanks so much @JeroenBos for taking the lead on this and helping out. |
Fixes #166.
Some remarks:
However, I did revert those breaking changes, so consider a squash merge.
PR meta checklist
DEVbranch.Content checklist