Closed
Conversation
scottsauber
commented
Mar 24, 2026
scottsauber
commented
Mar 24, 2026
| { | ||
| internal static string? GetAccessibleName(IElement element, INodeList rootNodes) | ||
| { | ||
| // 1. aria-labelledby — resolve each referenced ID, join with spaces |
Collaborator
Author
There was a problem hiding this comment.
This feels like we should consider our strategy pattern here.
scottsauber
commented
Mar 24, 2026
| var parent = element.ParentElement; | ||
| while (parent is not null) | ||
| { | ||
| if (parent.NodeName == "LABEL") |
Collaborator
Author
There was a problem hiding this comment.
We've got these magic strings in a few places... centralize?
scottsauber
commented
Mar 24, 2026
|
|
||
| private static bool MatchesOptions(IElement element, ByRoleOptions options, INodeList rootNodes) | ||
| { | ||
| // Name filter |
Collaborator
Author
There was a problem hiding this comment.
Strategy pattern?
Open
Collaborator
Author
|
Welp.... #1786 is better than this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
PR meta checklist
mainbranch for codeor targeted at
stablebranch for documentation that is live on bunit.dev.Code PR specific checklist
Addresses part of #938