Skip to content

Conversation

@grishat
Copy link
Contributor

@grishat grishat commented Nov 30, 2021

Pull request description

Added diff:ignoreChildren and diff:ignoreAttributes missed description in docs.

I closed the PR #571, and opened this one.

Adjusted the text so it is more obvious that ignoreChildren only ignores children and not attributes. Same with the ignoreAttributes modifier.
Also added a note that attributes can be combined.

PR meta checklist

  • Pull request is targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@grishat grishat closed this Nov 30, 2021
@grishat grishat reopened this Nov 30, 2021
@grishat
Copy link
Contributor Author

grishat commented Nov 30, 2021

I'm sorry, but my english is bad (

Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for updating the PR.

A few tweaks to the language. Really good point about combining the two new diff modifiers.

@egil egil linked an issue Nov 30, 2021 that may be closed by this pull request
Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you.

@egil egil merged commit 10c8511 into bUnit-dev:stable Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs related to AngleSharp Diffing 0.17

2 participants