Skip to content

Conversation

@pBouillon
Copy link
Contributor

Rework the documentation page

Fix the docs as described by the discussion in #869

bUnitBot and others added 10 commits September 16, 2022 16:22
Bumps [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) from 3.5.109 to 3.5.113.
- [Release notes](https://github.com/dotnet/Nerdbank.GitVersioning/releases)
- [Commits](dotnet/Nerdbank.GitVersioning@v3.5.109...v3.5.113)

---
updated-dependencies:
- dependency-name: Nerdbank.GitVersioning
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Egil Hansen <egil@assimilated.dk>
Update main with documentation in stable
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.1 to 17.3.2.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v17.3.1...v17.3.2)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@linkdotnet
Copy link
Collaborator

linkdotnet commented Oct 3, 2022

Hey @pBouillon thanks for handing in that nice PR.
Just a side note from my side. It seems that you branched off from main and not stable. That is why we see some merge commits and additional changes.

Would it be possible to branch of ffrom stable? Or alternatively (depending on how much of a git pro you are), you can do this (pretending you are on your branch):

git pull
git rebase --onto origin/stable origin/main
git push --force-with-lease

That commands rebases the from main to stable. Please do this only if you are confident with git.

@pBouillon
Copy link
Contributor Author

Hey @linkdotnet!

Thanks for the hint, I misunderstood the issue and thought that I should target stable but didn't get that it implied starting from it too, I'll fix that 😄

@pBouillon
Copy link
Contributor Author

I did not felt confident enough with the git commands you suggested so I did a separate PR to change the source and target branches on #877

I'll be closing this PR to avoid duplicates, let me know if I have to change anything else!

@pBouillon pBouillon closed this Oct 3, 2022
egil added a commit that referenced this pull request Oct 8, 2022
* Retrieve the modifications from #875

* Update docs/site/docs/getting-started/create-test-project.md

Co-authored-by: Egil Hansen <egil@assimilated.dk>

* Update docs/site/docs/getting-started/create-test-project.md

Co-authored-by: Egil Hansen <egil@assimilated.dk>

* Refrase the parts related to .NET 7 and the project creation

* Remove duplicated space

* Refrase the mentions of the section moved upwards

Co-authored-by: Egil Hansen <egil@assimilated.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants