Fix CI creating file#39
Merged
Merged
Conversation
Collaborator
|
HI @u5surf It looks great! There are two small issues, but if that is resolved we can merge it could. Is it possible to create and add yourself to the AUTHORS file? Also, please object if you have any issue with licensing your code under a free license later on. Thanks a lot! Valentijn |
ValentijnvdBeek
requested changes
Nov 14, 2021
| @@ -6,17 +6,26 @@ jobs: | |||
| # whenever you do end up solving this issue so that I know how many years have passed. | |||
| # Until that time, please manually run the test suite before pushing. Thanks. | |||
| # - ValentijnvdBeek | |||
Collaborator
There was a problem hiding this comment.
The comment here is obsolete so it would be nice if you where to delete it.
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| - name: Check version | ||
| run: | |
Collaborator
There was a problem hiding this comment.
I understand that this is here for debugging reasons. However would it not be better to remove this step before merging it? Or is there something I am missing?
Contributor
Author
There was a problem hiding this comment.
@ValentijnvdBeek
Ah, It's my fault. That is just using for debugging, Then, I removed it.
Collaborator
|
Thanks looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33