super is not working inside methods marked async (T6895)

[babel-bot]

Issue originally made by Dmitriy Krasnikov (dmitriy.krasnikov)

Bug information

• Babel version: 6.3.26
• Node version: 5.3
• npm version: 3.3.12

Options

{
  plugins:[
    "transform-async-to-generator",
  ]
}

Input code

export class BaseClass {
  async test(id){
    console.log(id);
  }
}
export class ChildClass extends BaseClass{
  async test(id){
    id=1;
    super.test(id);
  }
}

let cls = new ChildClass();
cls.test(5);

Description

Outputs:

export class BaseClass {
  test(id) {
    return _asyncToGenerator(function* () {
      console.log(id);
    })();
  }
}
export class ChildClass extends BaseClass {
  test(id) {
    return _asyncToGenerator(function* () {
      id = 1;
      super.test(id);
    })();
  }
}

let cls = new ChildClass();
cls.test(5);

[babel-bot]

Comment originally made by Paul Sanchez (basicdays)

I ran into this as well when upgrading from Babel 5 to 6. Seems the issue is the output is creating a generator but keeping the original super syntax. Generators don't have the ability to call super unfortunately. I'm guessing there will have to be a transformer to just transpile super references within just async methods?

I have some example input/output code here: https://gist.github.com/psanchez-alertmd/5ffa9ff5e4653d9f93d8

[babel-bot]

Comment originally made by Paul Sanchez (basicdays)

Oh, this was created with babel 6.4.0, babel-preset-es2015-node4 2.0.2, and babel-preset-stage-3 v6.3.13. Here are the plugins it was pulling in: https://github.com/jbach/babel-preset-es2015-node4/blob/master/index.js

[babel-bot]

Comment originally made by @loganfsmyth

This is a tough one. We've got two options I see.

1. Add handling for this case to babel-helper-remap-async-to-generator to use babel-helper-replace-supers
2. Add general support to the internal shadow-functions.js transform so that at the same time we remap this to point at parent scopes, we do the same for super, since super and this are tied to the same function context.

[babel-bot]

Comment originally made by @loganfsmyth

Ended up going with #2.

#3423

[loganfsmyth]

For those coming across this, my recommendation for now would be to manually enable transform-es2015-classes which obviously isn't ideal, but does the job.

[matildayipan]

I have enabled transform-es2015-classes in .babelrc:

{
  "presets": ["es2015"],
  "plugins": ["transform-es2015-classes"]
}

still have the same error

[christensson]

@matildayipan If you are accessing super from within an async method, you still need to enable the async-function transformation:

{
  "plugins": [
    [
      "transform-es2015-classes"
    ],
    [
      "transform-async-to-module-method", {
        "module": "bluebird",
        "method": "coroutine"
      }
    ]
  ]
}

[develar]

Workaround: SuperClass.prototype.method.call(this): http://madole.xyz/babel-plugin-transform-async-to-module-method-gotcha/

[alexeyraspopov]

Any updates on this?

[tnunes]

Would also like to understand the state of this issue. Did we agree on the solution path? If so and with some general pointers, I can try to send a PR to address this.