Bundle more packages#17938
Conversation
JLHwung
added
the
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61334 |
|
commit: |
| // eslint-disable-next-line n/no-process-exit | ||
| process.on("message", () => process.exit(0)); | ||
| process.channel.unref(); | ||
| process.channel?.unref(); |
There was a problem hiding this comment.
Per TS error: process.channel may not be defined when the process is not spawned with the IPC channel (taskOpts.ipc)
| if (process.platform === "win32") { | ||
| fixtures = fixtures.slice(1); | ||
| } | ||
| testRunner(fixtures, "define-helper"); |
There was a problem hiding this comment.
The fixture folder is split into two fixtures, one is normal and the other is skip-bundled because define-helper.js depends on babel-helpers internals.
| tsconfig.json | ||
| tsconfig.tsbuildinfo | ||
| scripts | ||
| data |
There was a problem hiding this comment.
We can safely remove data from npm files because it will be bundled into the artifact.
| // todo: These package use #import conditions, that we want to leave unbundled. | ||
| // Eventually figure out how to bundle the rest. |
There was a problem hiding this comment.
I think we support it, right? The bundle logic will look at the #imports and mark them as entrypoints, since #17756
There was a problem hiding this comment.
Oh I see, this comment is just a leftover?
There was a problem hiding this comment.
Yeah these comments are just left as-is. Like you said we have already supported the #import conditions, I will remove them.
JLHwung
force-pushed
the
bundle-more-packages
branch
from
fac456d to
d67cfaf
Compare
4 participants
Fixes #1, Fixes #2As a follow-up to #14179, in this PR we bundle the following packages before publishing:
@babel/cli@babel/node@babel/helper-fixtures@babel/helpers@babel/register@babel/helper-transform-fixture-test-runner@babel/build-external-helpers@babel/eslint-parser@babel/eslint-plugin@babel/eslint-plugin-development@babel/eslint-plugin-development-internalThe build script is also tweaked a bit.
After this PR gets merged, there will be only 4 public packages that are not bundled by rollup:
@babel/compat-data(JSON only)@babel/helper-globals(JSON only)@babel/runtime(Many entrypoints, few value for bundling)@babel/runtime-corejs3(Many entrypoints, few value for bundling)