feat: event schema to have versions #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwbabylonlab
force-pushed
the
add-schema-version-control
branch
from
b1387a9 to
f561d31
Compare
gitferry
approved these changes
Aug 9, 2024
Member
gitferry
left a comment
gitferry
left a comment
There was a problem hiding this comment.
In general looks good to me. Can we add a test for backward compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started with version 0 as this would be the default version for old messages that not yet have such field.
i.e
json.Unmarshalwill treat the non-existent field as 0 value