Merged
Conversation
Author
|
It works now. The UI is ugly. I need to make a new pull request for the UI. |
teddphil
added
the
Completed & Waiting for Review
dominikbach
approved these changes
Jun 17, 2024
dominikbach
deleted the
718-warning-when-running-display-with-full-file-path
branch
teddphil
removed
the
Completed & Waiting for Review
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #718
Cause of the issue
The issue happened at line 32 in
pspm_display. This is a line that is iteratively used whenpspm_displayis running. Initially, thevararginis set to be the input ofpspm_display. In default,vararginis empty, so the line is not actually executed. In the next iteration,vararginbecomes a multi-cell cell array, which is whennarginis no longer 0. This will not consider the situation thatpspm_displayactually has an input.I am not fully clear what
gui_State.gui_Callbackis used for, since it is not really called much in this function. Therefore, I set a situation to identify whether it is processing the user's input asvarargin, and this situation is determined in line 38 of the new version.Changes proposed in this pull request:
varargin{1}refers to user's input, as a file name or a file path, it will no longer callstr2func. The situation for determining the input is a file name or a file path is that thevarargin{1}ends with.mat.