Skip to content

Fix issue 717 -- data_editor#724

Merged
dominikbach merged 4 commits intodevelopfrom
717-data-editor-does-not-show-output-file
Jun 17, 2024
Merged

Fix issue 717 -- data_editor#724
dominikbach merged 4 commits intodevelopfrom
717-data-editor-does-not-show-output-file

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Jun 17, 2024

Fixes #717.

The issue was caused by the settings of UI component display. The settings of displaying echo file component and output file component are managed at lines 131 to 136 in pspm_data_editor. The lines functioned as following:

  • If users call the GUI directly without specifying options in command, it will always display echo file and output file.
  • If users call the GUI with specifying options, it will only display output_file when users have not specified output_file, and will only display epoch_file if users have specified epoch_file.

I am not fully clear why the logic was set to be like this. I think maybe we can discuss about how we want to set this. Currently I have disabled these customisations, so the two epoch_file and output_file modules will always be displayed no matter how users specify options subfields.

@teddphil teddphil linked an issue Jun 17, 2024 that may be closed by this pull request
@teddphil teddphil changed the title Fix issue 717 -- data editor Fix issue 717 -- data_editor Jun 17, 2024
@teddphil teddphil requested a review from dominikbach June 17, 2024 03:19
@teddphil teddphil self-assigned this Jun 17, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Jun 17, 2024
@teddphil teddphil added this to the v7.0 milestone Jun 17, 2024
@teddphil teddphil marked this pull request as ready for review June 17, 2024 03:20
@dominikbach dominikbach merged commit 2f567cb into develop Jun 17, 2024
@dominikbach dominikbach deleted the 717-data-editor-does-not-show-output-file branch June 17, 2024 08:31
@teddphil teddphil removed the Completed & Waiting for Review Completed and waiting for review label Jun 24, 2024
@teddphil teddphil mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data editor does not show output file

2 participants