Merged
Conversation
added 2 commits
June 17, 2024 03:23
dominikbach
approved these changes
Jun 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #717.
The issue was caused by the settings of UI component display. The settings of displaying
echo filecomponent andoutput filecomponent are managed at lines 131 to 136 inpspm_data_editor. The lines functioned as following:optionsin command, it will always displayecho fileandoutput file.options, it will only displayoutput_filewhen users have not specifiedoutput_file, and will only displayepoch_fileif users have specifiedepoch_file.I am not fully clear why the logic was set to be like this. I think maybe we can discuss about how we want to set this. Currently I have disabled these customisations, so the two
epoch_fileandoutput_filemodules will always be displayed no matter how users specify options subfields.