Skip to content

Fix issue 676 -- adjust UI#725

Merged
dominikbach merged 7 commits intodevelopfrom
ui-adjustment
Jun 17, 2024
Merged

Fix issue 676 -- adjust UI#725
dominikbach merged 7 commits intodevelopfrom
ui-adjustment

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Jun 17, 2024

Fixes #676.

Issues fixed by this PR:

  • Previously PsPM cannot be started up in MATLAB 2019. Now it is fixed.
  • Previously PsPM UI text is not displayed fully when new desktop is enabled. Now it is fixed.
  • Previously PsPM main GUI gives a warning of unavailability of BorderColor. Now it is fixed.

I will use another PR to test for

  • windows, Matlab 2024a
  • windows, Matlab 2024a with new desktop
  • Linux, Matlab 2024a
  • Linux, Matlab 2024a with new desktop

@teddphil teddphil added this to the v7.0 milestone Jun 17, 2024
@teddphil teddphil linked an issue Jun 17, 2024 that may be closed by this pull request
@teddphil
Copy link
Copy Markdown
Author

I have been looking for a command to allow checking if users are using the new desktop, but the Matlab's add-on checking code does not seem to work.
image

@teddphil
Copy link
Copy Markdown
Author

teddphil commented Jun 17, 2024

macOS (Sonoma)

New desktop add-on enabled

Main GUI

image

Batch

Before

image

After

image

Data display

Before

image

After

image

Data editor

Before

image

After

image (This needs further refinement separately)

ECG editor

Before

image

After

image

Model review

Before

image

After

image

@teddphil teddphil changed the title Update pspm_ui.m Fix issue 676 -- adjust UI Jun 17, 2024
@teddphil
Copy link
Copy Markdown
Author

teddphil commented Jun 17, 2024

MS windows

Main GUI

Old desktop

image

Batch

Old desktop

image

Display

Old desktop

Before

image

After

image

Data editor

Old desktop

image

Review

Old desktop

image

@teddphil teddphil self-assigned this Jun 17, 2024
@teddphil teddphil requested a review from dominikbach June 17, 2024 15:40
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Jun 17, 2024
@teddphil teddphil marked this pull request as ready for review June 17, 2024 15:40
@dominikbach dominikbach merged commit b2d813d into develop Jun 17, 2024
@dominikbach dominikbach deleted the ui-adjustment branch June 17, 2024 16:08
@teddphil teddphil removed the Completed & Waiting for Review Completed and waiting for review label Jun 24, 2024
@teddphil teddphil mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor UI adjustment

2 participants