Skip to content

Fix issue 733#734

Merged
dominikbach merged 4 commits intodevelopfrom
733-spliting-acqread-and-acqread_python-from-pspm_get_acq
Jun 25, 2024
Merged

Fix issue 733#734
dominikbach merged 4 commits intodevelopfrom
733-spliting-acqread-and-acqread_python-from-pspm_get_acq

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Jun 24, 2024

Fixes #733.

Changes proposed in this pull request:

  • Split "get acq with python" and "get acq with classic methods".

Currently, "acq any version" (can be imported with get_acq_python) and "get acq equal to or earlier than version 3.9.0" (can be imported with get_acq) are split into two items in pspm_init.

Users can use get_acq to import acq files with the classic method or use get_acq_python to import acq files with the python package bioread.

@teddphil teddphil linked an issue Jun 24, 2024 that may be closed by this pull request
@teddphil teddphil changed the title add back two functions Fix issue 733 Jun 24, 2024
@teddphil teddphil requested a review from dominikbach June 24, 2024 22:09
@teddphil teddphil self-assigned this Jun 24, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Jun 24, 2024
@teddphil teddphil added this to the v7.0 milestone Jun 24, 2024
@teddphil teddphil marked this pull request as ready for review June 24, 2024 22:18
@teddphil
Copy link
Copy Markdown
Author

Screenshots

image
image

Note
"Bioread" is used as an item there because it wants to use the interface "pspm_cfg_selector_python". The title of this item has to be the name of the python package.

@dominikbach dominikbach merged commit 6444cae into develop Jun 25, 2024
@dominikbach dominikbach deleted the 733-spliting-acqread-and-acqread_python-from-pspm_get_acq branch June 25, 2024 06:16
@teddphil teddphil removed the Completed & Waiting for Review Completed and waiting for review label Aug 5, 2024
@teddphil teddphil mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spliting acqread and acqread_python from pspm_get_acq

2 participants