Merged
Conversation
dominikbach
added
the
Completed & Waiting for Review
… option when channel is of wrong type
teddphil
reviewed
Jul 29, 2024
There was a problem hiding this comment.
I fixed the issue of pspm_init in PR 746.
teddphil
approved these changes
Jul 29, 2024
teddphil
added
Approved
teddphil
removed
Bug
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple bugs and improvements identified during beta testing.
pspm_init(duplicated path removal, no warning if only required paths are already on the path)pspm_dcm/pspm_dcm_inv(argument valueinfis not recognised asintbypspm_options)pspm_extract_segments(normalisation with missing values,srfor glm)pspm_glm(wrong sample rate)pspm_trim(usepspm_load_channeland fix help text)pspm_glm(remove unnecessary and impossible orthogonalisation in edge case)pspm_get_timingandpspm_trimpspm_convert_hb2hpandpspm_resp_ppby using nearest neighbour instead of linear extrapolation (including a new regression test)pspm_multi2indexpspm_pupil_ppby using a different criterion for the decision on whether to combine pupils