Merged
Conversation
teddphil
added
the
Completed & Waiting for Review
dominikbach
approved these changes
Jul 30, 2024
teddphil
removed
the
Completed & Waiting for Review
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
GUI
The developer branch reports error when starting up PsPM with MATLAB 2019. There is because App designer has incompatibility between MATLAB 2019 and MATLAB 2020+. Therefore, a version of GUI that is optimised for MATLAB 2019 has been added in this PR.
Encoding
It is not guaranteed that MATLAB is using UTF-8 everywhere, but the current version of
pspm_helprequires recognition of special table drawing characters, such as┌. To fix this issue, ASCII code is used to define such characters inpspm_help, and no issues have been reported after implementing this PR.