Skip to content

Update pspm_display.m#751

Merged
dominikbach merged 4 commits intodevelopfrom
744-pspm_display-fails-in-develop-branch
Aug 5, 2024
Merged

Update pspm_display.m#751
dominikbach merged 4 commits intodevelopfrom
744-pspm_display-fails-in-develop-branch

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Aug 5, 2024

Fixes #744.

When a file is selected and I click on "done", the following error occurs (and the file selector remains frozen).

Cannot be replicated here... The function can run successfully.

When I close the file selector by clicking on the top-left cross, the following error message occurs

This is caused by the invalid usage of varargin at line 491--492 in pspm_display. That line of code is not really usable because varargin is not available inside load_Callback. This error has been fixed by removing these two lines.

Same error for pspm_review in develop branch, using models that were computed by the same version.

The issue is caused by unuqdated pspm_rev_glm . In pspm_review, it calls pspm_rev_glm by using three variables, but the second variable it calls is no longer needed in pspm_rev_glm. This has been updated in pspm_review and function description of pspm_rev_glm.

@teddphil teddphil linked an issue Aug 5, 2024 that may be closed by this pull request
@teddphil teddphil requested a review from dominikbach August 5, 2024 04:08
@teddphil teddphil self-assigned this Aug 5, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Aug 5, 2024
@teddphil teddphil added this to the v7.0 milestone Aug 5, 2024
@teddphil teddphil marked this pull request as ready for review August 5, 2024 04:16
@dominikbach dominikbach merged commit e49fcc0 into develop Aug 5, 2024
@dominikbach dominikbach deleted the 744-pspm_display-fails-in-develop-branch branch August 5, 2024 06:59
@teddphil teddphil removed the Completed & Waiting for Review Completed and waiting for review label Aug 11, 2024
@teddphil teddphil mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pspm_display fails in develop branch

2 participants