Skip to content

Fix issue 692 -- remove varargout#754

Merged
teddphil merged 5 commits intodevelopfrom
692-remove-varargout-in-remaining-functions
Aug 7, 2024
Merged

Fix issue 692 -- remove varargout#754
teddphil merged 5 commits intodevelopfrom
692-remove-varargout-in-remaining-functions

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Aug 5, 2024

Fixes #692.

Changes proposed in this pull request:

  • remove varargout in remaining functions, namely
    • data_editor
    • display
    • ecg_editor
    • filtfilt
    • find_channel
    • jobman
    • load1
    • overwrite
    • prepdata
    • pulse_convert
    • pupil_pp
    • rev_dcm
    • rev_glm
    • tam

@teddphil teddphil linked an issue Aug 5, 2024 that may be closed by this pull request
@teddphil teddphil marked this pull request as ready for review August 5, 2024 10:24
@teddphil teddphil self-assigned this Aug 5, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Aug 5, 2024
@teddphil teddphil requested a review from dominikbach August 5, 2024 10:24
@teddphil teddphil added this to the v7.0 milestone Aug 5, 2024
@dominikbach dominikbach added Approved The pull request has been approved and can be checked and then merged. and removed Completed & Waiting for Review Completed and waiting for review labels Aug 5, 2024
@teddphil
Copy link
Copy Markdown
Author

teddphil commented Aug 5, 2024

Hi @dominikbach Thanks for approving this. Please kindly allow me a little time to update the description of these functions in documents.

@teddphil teddphil merged commit c5644a3 into develop Aug 7, 2024
@teddphil teddphil deleted the 692-remove-varargout-in-remaining-functions branch August 7, 2024 00:29
@teddphil teddphil removed the Approved The pull request has been approved and can be checked and then merged. label Aug 11, 2024
@teddphil teddphil mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove varargout in remaining functions

2 participants