Skip to content

Fix issue 407#761

Merged
dominikbach merged 19 commits intodevelopfrom
407-a-global-variable-refering-to-the-gui-plotting-window
Sep 23, 2024
Merged

Fix issue 407#761
dominikbach merged 19 commits intodevelopfrom
407-a-global-variable-refering-to-the-gui-plotting-window

Conversation

@teddphil
Copy link
Copy Markdown

@teddphil teddphil commented Aug 12, 2024

Fixes #407.

The global option proposed from the issue description is not currently found useful.
All the four GUI functions can run without plotting on the GUI. Details are listed below.
Minor updates are provided to the GUI functions: making the tag name of the GUI to be the name of the corresponding function, i.e. the tag of the GUI "pspm_data_editor.fig" is now "pspm_data_editor", instead of "fgDataEditor". This is to make things consistent and avoid future confusion.


Update 23 Sep 2024

The current status

  1. The "UIWait" can disable user's command line input (such as plot(1:2)) during running a function and expect users to do multiple GUI operations.
  • In the develop branch, pspm_display and pspm_review will allow users to type in command line during running the GUI, but pspm_ecg_editor and pspm_data_editor do not allow. This means pspm_ecg_editor and pspm_data_editor will never make the user's commands displaying in the GUI since they are disabled.
Screenshot 2024-09-23 at 10 05 19

pspm_display

For pspm_display, after I call a new plot when pspm_display is running, the plot directly displays as a separate figure, rather than showing in the GUI. I think this is expected. Please see video below.

720p.mov

If I call the function by displaying a specific file, then plot something, it also works as expect

image

pspm_review

For pspm_review, there are two situations

  • If the user has plotted something from the model, e.g. clicking "display all trials for one session", then the new plots will overwrite the plotted figures. Please check below
image

After running plot([1,2,3])
image

However, if the user has not plotted anything, and try to plot new information when they are only running the GUI of pspm_review, the new plot will run as a separate figure.
image

@teddphil teddphil linked an issue Aug 12, 2024 that may be closed by this pull request
@teddphil teddphil requested a review from dominikbach August 12, 2024 18:56
@teddphil teddphil self-assigned this Aug 12, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Aug 12, 2024
@teddphil teddphil added this to the v7.0 milestone Aug 12, 2024
dadi.zhao added 2 commits August 12, 2024 20:42
axData shall be always writable
Loadfromfile has included plot so no longer needed to use "PlotData" againt
@teddphil teddphil marked this pull request as ready for review August 12, 2024 20:14
@dominikbach dominikbach added In Progress Currently being worked on and removed Completed & Waiting for Review Completed and waiting for review labels Sep 9, 2024
@teddphil teddphil removed the In Progress Currently being worked on label Sep 23, 2024
@teddphil teddphil added the Completed & Waiting for Review Completed and waiting for review label Sep 23, 2024
@dominikbach dominikbach merged commit 7499c28 into develop Sep 23, 2024
@dominikbach dominikbach deleted the 407-a-global-variable-refering-to-the-gui-plotting-window branch September 23, 2024 11:58
@teddphil teddphil removed the Completed & Waiting for Review Completed and waiting for review label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A global variable refering to the GUI plotting window

2 participants