Merged
Conversation
added 2 commits
August 12, 2024 20:42
axData shall be always writable Loadfromfile has included plot so no longer needed to use "PlotData" againt
added 3 commits
August 23, 2024 10:17
added 2 commits
September 9, 2024 22:28
added 3 commits
September 23, 2024 11:00
dominikbach
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.
The global option proposed from the issue description is not currently found useful.
All the four GUI functions can run without plotting on the GUI. Details are listed below.
Minor updates are provided to the GUI functions: making the tag name of the GUI to be the name of the corresponding function, i.e. the tag of the GUI "pspm_data_editor.fig" is now "pspm_data_editor", instead of "fgDataEditor". This is to make things consistent and avoid future confusion.
Update 23 Sep 2024
The current status
plot(1:2)) during running a function and expect users to do multiple GUI operations.pspm_displayandpspm_reviewwill allow users to type in command line during running the GUI, butpspm_ecg_editorandpspm_data_editordo not allow. This meanspspm_ecg_editorandpspm_data_editorwill never make the user's commands displaying in the GUI since they are disabled.pspm_display
For
pspm_display, after I call a new plot whenpspm_displayis running, the plot directly displays as a separate figure, rather than showing in the GUI. I think this is expected. Please see video below.720p.mov
If I call the function by displaying a specific file, then plot something, it also works as expect
pspm_review
For
pspm_review, there are two situationsAfter running

plot([1,2,3])However, if the user has not plotted anything, and try to plot new information when they are only running the GUI of

pspm_review, the new plot will run as a separate figure.