Merged
Conversation
correct import for both eyes
Collaborator
|
hi @ZhangSihui999, Thank you so much for your pull request! We appreciate the effort you put into this. I have a quick question: does this fix address a general issue, or is it specific to the data you’re working on? If possible, could you share some sample data with us? This would be super helpful for us to test the fix on our end. |
Contributor
Author
|
Dear PsPM team,
Thank you for your email. I am very glad that I could help.
I discovered this problem when I tried to import a pilot dataset with both
eyes recorded. I didn't have problems of importing my old dataset with only
one eye recorded. When doing debugging, I found that the relavant code is
for reading message "RECCFG" from the asc file.
In my old dataset, this line of message is like this: MSG 2451268 RECCFG
CR 1000 2 1 R.
While in the new pilot dataset, the message is slightly different: MSG
156091 RECCFG CR 1000 2 1 2 1 LR.
I am not 100% sure if this is a general issue but I would assume so. I
attached the pilot file so that you could have a look.
pup_600.asc
<https://drive.google.com/file/d/1uIjrtVGd2a-1PXhCVOXflaUzXM93Mgoh/view?usp=drive_web>
Please let me know if you have any further questions.
Best wishes,
Sihui
Bernhard ***@***.***> 于2024年10月28日周一 13:57写道:
… hi @ZhangSihui999 <https://github.com/ZhangSihui999>,
Thank you so much for your pull request! We appreciate the effort you put
into this.
I have a quick question: does this fix address a general issue, or is it
specific to the data you’re working on? If possible, could you share some
sample data with us? This would be super helpful for us to test the fix on
our end.
—
Reply to this email directly, view it on GitHub
<#793 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKH6WEUYKDFPNSUNCQG4C7LZ5YRAZAVCNFSM6AAAAABQOVOW46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGUYTMMJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dominikbach
added a commit
that referenced
this pull request
Dec 16, 2024
Changes to "Update import_eyelink.m #793"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correct import for both eyes
Fixes # .
Changes proposed in this pull request: