Skip to content

fix illuminance GUI#799

Merged
dominikbach merged 4 commits intodevelopfrom
fix_illuminance_gui
Nov 25, 2024
Merged

fix illuminance GUI#799
dominikbach merged 4 commits intodevelopfrom
fix_illuminance_gui

Conversation

@dominikbach
Copy link
Copy Markdown
Contributor

@dominikbach dominikbach commented Nov 14, 2024

Changes proposed in this pull request:

  • removes the response function options "duration" and "offset" from the illuminance GLM. There is no point changing these two if the other parameters cannot be changed.

@dominikbach dominikbach requested a review from 4gwe November 14, 2024 11:19
@dominikbach dominikbach self-assigned this Nov 14, 2024
@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Nov 14, 2024
@dominikbach dominikbach added this to the v7.0 milestone Nov 14, 2024
4gwe
4gwe approved these changes Nov 25, 2024
View reviewed changes
Comment thread src/pspm_bf_lcrf_gm.m
@dominikbach dominikbach merged commit 3f487e9 into develop Nov 25, 2024
@dominikbach dominikbach deleted the fix_illuminance_gui branch November 25, 2024 12:41
@teddphil teddphil mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4gwe 4gwe 4gwe approved these changes

Assignees

@dominikbach dominikbach

Labels

Completed & Waiting for Review Completed and waiting for review

Projects

None yet

Milestone

v7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dominikbach @4gwe