Skip to content

fix smrx and associated bugs#814

Merged
dominikbach merged 1 commit intodevelopfrom
fix-smrx
Jan 7, 2025
Merged

fix smrx and associated bugs#814
dominikbach merged 1 commit intodevelopfrom
fix-smrx

Conversation

@dominikbach
Copy link
Copy Markdown
Contributor

@dominikbach dominikbach commented Jan 7, 2025

Fixes #811 .

Changes proposed in this pull request:

  • fix a bug in smrx import when searching for channel
  • fix a bug in smrx import that would turn all warnings off and not on again
  • fix a bug in import that would prevent a file from being overwritten when the user is asked via dialogue

@dominikbach dominikbach requested a review from teddphil January 7, 2025 18:03
@dominikbach dominikbach self-assigned this Jan 7, 2025
@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Jan 7, 2025
@dominikbach dominikbach added this to the v7.0 milestone Jan 7, 2025
teddphil
teddphil approved these changes Jan 7, 2025
View reviewed changes
Copy link
Copy Markdown

@teddphil teddphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

@teddphil teddphil added Approved The pull request has been approved and can be checked and then merged. and removed Completed & Waiting for Review Completed and waiting for review labels Jan 7, 2025
@dominikbach dominikbach merged commit dc412be into develop Jan 7, 2025
@dominikbach dominikbach deleted the fix-smrx branch January 7, 2025 19:38
@4gwe 4gwe mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teddphil teddphil teddphil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dominikbach dominikbach

Labels

Approved The pull request has been approved and can be checked and then merged.

Projects

None yet

Milestone

v7.0

Development

Successfully merging this pull request may close these issues.

Import smrx error

2 participants

@dominikbach @teddphil