Skip to content

794 pupil custom setting#815

Merged
dominikbach merged 10 commits intodevelopfrom
794_pupil_custom_setting
Jan 26, 2025
Merged

794 pupil custom setting#815
dominikbach merged 10 commits intodevelopfrom
794_pupil_custom_setting

Conversation

@4gwe
Copy link
Copy Markdown
Collaborator

@4gwe 4gwe commented Jan 11, 2025

Fixes #794

Changes proposed in this pull request:

  • update pspm_pupil_pp_options such as to compute filter coefficients from the settings provided by user
  • these will then be used by the external toolbox

4gwe added 3 commits January 11, 2025 14:20
…ng in the batcheditor (pspm_cfg_pupil_preprocess.m

)  ResdFiltLPCF.val      100 -> 16(raw)
@4gwe 4gwe requested a review from dominikbach January 11, 2025 15:23
@dominikbach dominikbach added the In Progress Currently being worked on label Jan 11, 2025
@dominikbach dominikbach added this to the v7.0 milestone Jan 11, 2025
@dominikbach dominikbach added the Approved The pull request has been approved and can be checked and then merged. label Jan 25, 2025
@dominikbach dominikbach removed the In Progress Currently being worked on label Jan 25, 2025
@dominikbach dominikbach merged commit ff115a0 into develop Jan 26, 2025
@dominikbach dominikbach deleted the 794_pupil_custom_setting branch January 26, 2025 12:59
@4gwe 4gwe mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved The pull request has been approved and can be checked and then merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pupil preprocessing custom setting

2 participants