Set zval and pval of main model params to NA#285
Merged
pschil merged 3 commits intodevelopmentfrom Jul 17, 2025
Merged
Conversation
As they are by definition always >0 and assessing their significance is pointless
There was a problem hiding this comment.
Pull Request Overview
This PR updates the summary method for fitted CLV models to blank out (set to NA) the z-value and p-value columns for the main model parameters, since their significance is always >0 by definition.
- Assigns
NA_real_to the"z-val"and"Pr(>|z|)"columns for the original model parameters - Adds explanatory comments detailing why
NAwas chosen over printing"-"
Comments suppressed due to low confidence (2)
R/f_s3generics_clvfitted.R:373
- The comment refers to "Pvalue" but the column name used is
Pr(>|z|). Consider updating the comment to match the actual column label for clarity.
# Set z-val and Pvalue of the model parameters to NA as they are by definition always > 0 ("significant")
R/f_s3generics_clvfitted.R:379
- There's no accompanying unit test verifying that
summary.clv.fitted()indeed sets these values toNA. Adding a test for this behavior would prevent regressions.
res$coefficients[object@clv.model@names.original.params.model, c("z-val", "Pr(>|z|)")] <- NA_real_
pschil
added a commit
that referenced
this pull request
Oct 29, 2025
As went to CRAN: * Version bump * Bugfix tests: Usage of apparelDynCov data (#287) * Set zval and pval of main model params to NA (#285) * Predict: Rename x.total.spending to x.period.spending (#286) * Dyncov: Rename predicted.CLV -> predicted.period.CLV (#288) * Add hessian(): Calculate hessian for fitted models (#289) * Docu: summary() significance indicators NA (#294) * clv.fitted.get.LL(): Method required for parameter bootstrap (#293) * Vignette: Add authors (#291) * clvdata(): Parameter data.end (#292) * Add vignettes: PDFs as-is (#295) * Rcpp: arma::is_finite() -> std::isfinite() (#296) * Vignettes: Compact during build * Update vignettes and compact before build * Prepare release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By definition, they are always >0 and assessing their significance is pointless