Skip to content

Add Python 3.5.3 support#12

Merged
bachya merged 4 commits intodevfrom
35
Oct 3, 2018
Merged

Add Python 3.5.3 support#12
bachya merged 4 commits intodevfrom
35

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Oct 3, 2018

Describe what the PR does:

This PR adds Python 3.5.3 as a supported version. This is principally done to support the current requirement that Home Assistant supports 3.5.3.

NOTE: aresponses (which the library currently uses for aiohttp testing) uses literal string interpolation, which requires Python 3.6. Therefore, although the library "supports" 3.5.3, testing (and anything related to testing, including Travis) must have a minimum of 3.6.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests is written for the new functionality.
  • Update README.md with any new documentation.
  • Run tests and ensure 100% code coverage: make coverage (after running make init)
  • Ensure you have no linting errors: make lint (after running make init)
  • Ensure you have no typed your code correctly: make typing (after running make init)
  • Add yourself to AUTHORS.md.

@bachya bachya self-assigned this Oct 3, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2018

Codecov Report

Merging #12 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #12   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         5      5           
  Lines       247    247           
===================================
  Hits        247    247

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa54e9...3f11378. Read the comment docs.

@bachya bachya merged commit 21c187c into dev Oct 3, 2018
@bachya bachya deleted the 35 branch October 3, 2018 20:30
@bachya bachya changed the title Initial commit Add Python 3.5.3 support Oct 3, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant