Skip to content

Re-introduce websocket functionality#259

Merged
bachya merged 5 commits intodevfrom
websocket
Oct 6, 2021
Merged

Re-introduce websocket functionality#259
bachya merged 5 commits intodevfrom
websocket

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Sep 29, 2021

Describe what the PR does:

With #258, we have everything we need to re-introduce a near-realtime websocket connection! Functionality will remain the same.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md and docs/ with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Sep 29, 2021
@bachya bachya self-assigned this Sep 29, 2021
Comment thread simplipy/websocket.py
Comment thread simplipy/websocket.py
@bachya bachya changed the title Websocket Re-introduce websocket functionality Sep 29, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2021

Codecov Report

Merging #259 (df3e08d) into dev (8482986) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               dev      #259    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           12        13     +1     
  Lines          694       880   +186     
==========================================
+ Hits           694       880   +186     
Impacted Files Coverage Δ
simplipy/api.py 100.00% <100.00%> (ø)
simplipy/const.py 100.00% <100.00%> (ø)
simplipy/errors.py 100.00% <100.00%> (ø)
simplipy/websocket.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8482986...df3e08d. Read the comment docs.

Comment thread simplipy/websocket.py
@qlty-cloud-legacy

This comment has been minimized.

@bachya bachya marked this pull request as ready for review October 6, 2021 00:16
@bachya bachya merged commit b67f11f into dev Oct 6, 2021
@bachya bachya deleted the websocket branch October 6, 2021 00:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant