Ensure that the refresh token is only used within the expiration window#266
Merged
Ensure that the refresh token is only used within the expiration window#266
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #266 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 886 893 +7
=========================================
+ Hits 886 893 +7
Continue to review full report at Codecov.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
Previously, when a request would encounter a 401 backoff, the library would attempt to refresh the access token for each of those requests, often leading to collisions where the refresh token would become invalid. This PR ensures that backoff will only try the refresh token if the last time it was used is outside of the expiration window.
Does this fix a specific issue?
N/A
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.