Skip to content

Fix websocket watchdog not canceling when websocket disconnects#293

Merged
bachya merged 1 commit intodevfrom
fix-watchdog-cance
Nov 16, 2021
Merged

Fix websocket watchdog not canceling when websocket disconnects#293
bachya merged 1 commit intodevfrom
fix-watchdog-cance

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Nov 16, 2021

Describe what the PR does:

The websocket watchdog wasn't properly canceling when we disconnected from the websocket. This could create an unnecessary loop of the watchdog triggering. This PR fixes things.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md and docs/ with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Nov 16, 2021
@bachya bachya self-assigned this Nov 16, 2021
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 4e6e167 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2021

Codecov Report

Merging #293 (4e6e167) into dev (833be42) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #293   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          13       13           
  Lines         903      903           
=======================================
  Hits          901      901           
  Misses          2        2           
Impacted Files Coverage Δ
simplipy/websocket.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833be42...4e6e167. Read the comment docs.

@bachya bachya merged commit fc208c7 into dev Nov 16, 2021
@bachya bachya deleted the fix-watchdog-cance branch November 16, 2021 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bugs or issues which will cause a problem for users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant