Fix websocket watchdog not canceling when websocket disconnects#293
Merged
Fix websocket watchdog not canceling when websocket disconnects#293
Conversation
|
Code Climate has analyzed commit 4e6e167 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## dev #293 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 13 13
Lines 903 903
=======================================
Hits 901 901
Misses 2 2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
The websocket watchdog wasn't properly canceling when we disconnected from the websocket. This could create an unnecessary loop of the watchdog triggering. This PR fixes things.
Does this fix a specific issue?
N/A
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.