Skip to content

Fix incorrect padding in the access token expiration datetime#294

Merged
bachya merged 1 commit intodevfrom
padding
Nov 17, 2021
Merged

Fix incorrect padding in the access token expiration datetime#294
bachya merged 1 commit intodevfrom
padding

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Nov 17, 2021

Describe what the PR does:

My logic for storing the access token's expiration datetime (appropriately padded) was incorrect. This could result in multiple successful (but unnecessary) requests to refresh the access token if those requests are within microseconds of each other. This PR fixes the logic.

Does this fix a specific issue?

N.A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md and docs/ with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Nov 17, 2021
@bachya bachya self-assigned this Nov 17, 2021
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit b976234 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2021

Codecov Report

Merging #294 (b976234) into dev (3167e43) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #294   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          13       13           
  Lines         903      903           
=======================================
  Hits          901      901           
  Misses          2        2           
Impacted Files Coverage Δ
simplipy/api.py 98.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3167e43...b976234. Read the comment docs.

@bachya bachya merged commit bffc716 into dev Nov 17, 2021
@bachya bachya deleted the padding branch November 17, 2021 00:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bugs or issues which will cause a problem for users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant