Skip to content

Automatic refresh token#7

Merged
bachya merged 4 commits intodevfrom
refresh
Sep 29, 2018
Merged

Automatic refresh token#7
bachya merged 4 commits intodevfrom
refresh

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Sep 28, 2018

Describe what the PR does:

In order to more fully support the Home Assistant use case, this PR makes the following changes:

  1. The library implemented no longer has to manually catch a TokenExpiredError and refresh the access token; that is done automatically.
  2. Instead of a get_systems() method, the SimpliSafe object now provides class methods for instantiation via username/password or refresh token.

This is a breaking change. Read the documentation for new API usage.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests is written for the new functionality.
  • Update README.md with any new documentation.
  • Run tests and ensure 100% code coverage: make coverage (after running make init)
  • Ensure you have no linting errors: make lint (after running make init)
  • Ensure you have no typed your code correctly: make typing (after running make init)
  • Add yourself to AUTHORS.md.

@bachya bachya self-assigned this Sep 28, 2018
Repository owner deleted a comment from codecov bot Sep 28, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2018

Codecov Report

Merging #7 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev     #7   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         5      5           
  Lines       241    247    +6     
===================================
+ Hits        241    247    +6
Impacted Files Coverage Δ
simplipy/errors.py 100% <ø> (ø) ⬆️
simplipy/system.py 100% <100%> (ø) ⬆️
simplipy/api.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da9206...de19aee. Read the comment docs.

@bachya bachya merged commit 354924c into dev Sep 29, 2018
@bachya bachya deleted the refresh branch September 29, 2018 00:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant