Updated sensor.py to include ability to status entry sensors#8
Closed
qpe123 wants to merge 2 commits intobachya:devfrom
Closed
Updated sensor.py to include ability to status entry sensors#8qpe123 wants to merge 2 commits intobachya:devfrom
qpe123 wants to merge 2 commits intobachya:devfrom
Conversation
Added entryStatus for Open/Close sensors, returns open or closed for valid entry sensors for all other devices returns null
bachya
requested changes
Sep 28, 2018
Owner
There was a problem hiding this comment.
A few comments. Additionally, before this can be merged, please make sure you complete these administrative steps:
- Rebase your branch from the latest
devbranch so that you're up to date. - Update
README.md's examples to demonstrate that this new property exists for V2 systems. - Add a test that covers this new code.
- Ensure that Travis passes; it's currently failing due to a linting issue.
Thanks!
| return self.sensor_data['setting'] | ||
|
|
||
| @property | ||
| def entrystatus(self) -> str: |
Owner
There was a problem hiding this comment.
Let's use entry_status as a property name.
|
|
||
| @property | ||
| def entrystatus(self) -> str: | ||
| if self._type == SensorTypes.entry: |
Owner
There was a problem hiding this comment.
Owner
|
While investigating further, I don't think this is the correct approach. The goal should be to provide an as-common-as-possible interface between V2 and V3 systems.
Since this PR is well behind the dev base and is nearing a week of inactivity, I'm going to close it and apply these principles via a new PR. Thanks for your assistance! |
Author
|
Yeah I apologize and didn't get a chance to redo the merge as I have been
traveling... I only have a v2 system so couldn't determine the call for v3,
but sounds like you got it covered so no issue at all with you moving it
forward.
Thanks,
Quinn
…On Wed, Oct 3, 2018, 13:51 Aaron Bach ***@***.***> wrote:
While investigating further, I don't think this is the correct approach.
The goal should be to provide an as-common-as-possible interface between V2
and V3 systems.
- V2 entry sensors have an entryStatus property that can be open or
closed.
- V3 systems utilize the status.triggered property chain to
communicate the same information (but with values of true or false).
Since this PR is well behind the dev base and is nearing a week of
inactivity, I'm going to close it and apply these principles via a new PR.
Thanks for your assistance!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AppCG-7kjGPreXf16VWNSvtNiUw6ihr0ks5uhPk3gaJpZM4W93Y9>
.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated sensor.py to include ability to status entry sensors