Skip to content

Conversation

@VasasA
Copy link
Member

@VasasA VasasA commented Apr 6, 2019

regex.inc can replace more functions: #12

klonos and others added 2 commits April 11, 2019 20:43
Co-Authored-By: VasasA <8567234+VasasA@users.noreply.github.com>
Co-Authored-By: VasasA <8567234+VasasA@users.noreply.github.com>
@docwilmot
Copy link
Member

Apart from the coding standards suggestions @klonos made, I don't think these conversions can be mapped exactly as suggested. For example a hook_page_build() implementation cant just be renamed to hook_preprocess_page() as the two function would have been doing different things, and it would be entirely possible the D7 site would have had both functions. I'm similarly not sure about the backdrop_sort() switches, but havent checked. In all this still needs some work.

@VasasA
Copy link
Member Author

VasasA commented Nov 4, 2019

@docwilmot Please ignore and close my PR, and use the replacements only what are sure to work. For example: hook_library() -> hook_library_info()
https://api.backdropcms.org/change-records/hooklibrary-and-hooklibraryalter-have-been-renamed-hooklibraryinfo-and

bugfolder and others added 9 commits December 18, 2021 10:22
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
Co-authored-by: Greg Netsas <klonos@gmail.com>
bugfolder and others added 2 commits December 18, 2021 10:58
Co-authored-by: Greg Netsas <klonos@gmail.com>
@bugfolder
Copy link
Collaborator

Closing this PR and making selected changes from it in PR #67.

@bugfolder bugfolder closed this Dec 18, 2021
@bugfolder bugfolder mentioned this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants