Merged
Conversation
…f the name. I changed line 625 to be role->name and now the user import works fine.
Collaborator
|
Thank you! Merged |
Contributor
|
Just a side comment about this PR. This PR correctly assigns You can actually see how // Prepare user roles.
if (isset($entity->roles)) {
$entity->roles = array_values(array_filter($entity->roles));
} |
Collaborator
|
Good catch @argiepiano. I'm happy to just remove the key in a new commit. Just to have it cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using the user import and found out that the role is being set in the database with the role label instead of the machine name. I looked at the code and in the FeedUserProcessor.inc file on line 625 and noticed the entity role was being set with role label. I changed that line to set with the role name and the issue was resolved.