Issue #34. Correctly remove field data, info and instance when uninstalling#113
Merged
argiepiano merged 1 commit intobackdrop-contrib:1.x-2.xfrom May 27, 2022
Merged
Conversation
…ance when uninstalling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Explanation: there were two problems:
og_membership_requestnot being removed at all (field info, field instance and data). This happens also in the D7 version. The entity to which it's attached,og_membership, has been deleted and therefore the removal of the field needed some special treatmentfield_purge_batchat the end of the uninstall hook, as recommended in some D7 posts.Tested thoroughly - working fine.