Issue #32. Check that group field type is not empty#71
Merged
laryn merged 1 commit intobackdrop-contrib:1.x-2.xfrom Apr 25, 2022
Merged
Conversation
Fixes backdrop-contrib#32. This small tweak of `og_is_group_audience_field()` is necessary in PHP 7.4+ in order for `OgGroupAndUngroup` to pass. This tweak also helps catch typos in field names, or wrong field names - it avoids throwing an Exception for a null array offset in PHP 7.4+
Closed
Collaborator
Author
|
IMPORTANT: for this fix to have an effect and allow |
Member
|
I merged #64, then closed and reopened this PR to trigger tests again. |
Member
|
✅ Organic groups: OG group and ungroup (OgGroupAndUngroup) 28 passes, 0 fails, and 0 exceptions. [10.078s] |
Member
|
Thanks @argiepiano! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32 for
OgGroupAndUngrouptestsThis small tweak of
og_is_group_audience_field()is necessary in PHP 7.4+ in order forOgGroupAndUngroupto pass.This tweak also helps catch typos in field names, or wrong field names - it avoids throwing an Exception for a null array offset in PHP 7.4+