Skip to content

PHPCS major version breaking changes (4.x) #24

@indigoxela

Description

@indigoxela

Currently our phpcs GHA doesn't run. It has to do with the latest phpcs major version, which came out last week:

https://github.com/PHPCSStandards/PHP_CodeSniffer/releases

Errors in GHA:

ERROR: Referenced sniff "Squiz.Classes.DuplicateProperty" does not exist.
ERROR: Referenced sniff "Squiz.Debug.JSLint" does not exist.
ERROR: Referenced sniff "Squiz.Debug.JavaScriptLint" does not exist.
ERROR: Referenced sniff "Squiz.Objects.DisallowObjectStringIndex" does not exist.
ERROR: Referenced sniff "Squiz.Objects.ObjectMemberComma" does not exist.
ERROR: Referenced sniff "Squiz.WhiteSpace.LanguageConstructSpacing" does not exist.
ERROR: Referenced sniff "Squiz.WhiteSpace.PropertyLabelSpacing" does not exist.

Those rules are used in our Backdrop/ruleset.xml

There's an upgrade guide: https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-User-Upgrade-Guide#upgrading-3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions