Skip to content

Issue #5853: Prevent errors caused by translated string on template export#4251

Merged
quicksketch merged 1 commit intobackdrop:1.xfrom
indigoxela:5853-fatal-template-export
Nov 10, 2022
Merged

Issue #5853: Prevent errors caused by translated string on template export#4251
quicksketch merged 1 commit intobackdrop:1.xfrom
indigoxela:5853-fatal-template-export

Conversation

@indigoxela
Copy link
Copy Markdown
Member

@backdrop-ci
Copy link
Copy Markdown
Collaborator

Related to: backdrop/backdrop-issues#5853

@indigoxela indigoxela changed the title Issue #5853: Prevent errors caused by translated string on template export Issue #5853: Prevent errors caused by translated string on template export [skip tests] Nov 3, 2022
@indigoxela
Copy link
Copy Markdown
Member Author

Weird phpcs prob.

@indigoxela indigoxela closed this Nov 3, 2022
@indigoxela indigoxela reopened this Nov 3, 2022
@indigoxela indigoxela changed the title Issue #5853: Prevent errors caused by translated string on template export [skip tests] Issue #5853: Prevent errors caused by translated string on template export Nov 3, 2022
@indigoxela
Copy link
Copy Markdown
Member Author

Back to running functional tests, although the phpcs check will still fail.

@indigoxela indigoxela closed this Nov 3, 2022
@indigoxela indigoxela reopened this Nov 3, 2022
@dragonbot
Copy link
Copy Markdown
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr4251-uso0k0xspph4e8wjtywkip2cykbhilsn.tugboatqa.com/
Username: admin
Password: a114faefc34d

This preview will automatically expire on the 3rd of January, 2023.

@djzwerg
Copy link
Copy Markdown
Contributor

djzwerg commented Nov 3, 2022

PR applied and this fixes the related issue backdrop/backdrop-issues#5853. Thanks a lot @indigoxela !

Copy link
Copy Markdown
Contributor

@djzwerg djzwerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks!

@quicksketch
Copy link
Copy Markdown
Member

Thanks! Merged into 1.x and 1.23.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed: Exports of flexible templates throw PHP 8 error when System language is not English.

5 participants