Issue #7061: Fix broken PHP 7.1 compatibility#5204
Conversation
|
Related to: backdrop/backdrop-issues#7061 |
|
Tugboat has finished building a preview for this pull request! Website: https://pr5204-nognwxaopd4hwjw9vyqmlzpjnlbtrqlc.tugboatqa.com/ This preview will automatically expire on the 21st of March, 2026. |
| * Whether to acquire a lock before writing to cache. | ||
| */ | ||
| protected function set(array $data, $lock = TRUE) { | ||
| protected function set($data, $lock = TRUE) { // phpcs:ignore |
There was a problem hiding this comment.
Should we add some hint, that we can't use a type hint, because of at least one known class in core extending BackdropCacheArray? Or should the issue discussion be sufficient?
There was a problem hiding this comment.
Let's move forward with this as-is. The problem of adding type-hints as required by our PHPCS rules but not being backwards-compatible is going to be a wide-reaching problem.
|
I merged this and cherry-picked back into 1.33.x and 1.32.x (where this regression was also made). Thank you @indigoxela! |
4 participants
Fixes backdrop/backdrop-issues#7061
Tests run again on 7.1 and, of course, unrelated BareUpgradePathTestCase, was eager to fail. 🙄