Skip to content

Add the ability to auto close the tab on approval#128

Merged
backnotprop merged 2 commits intobacknotprop:mainfrom
senxd:main
Feb 11, 2026
Merged

Add the ability to auto close the tab on approval#128
backnotprop merged 2 commits intobacknotprop:mainfrom
senxd:main

Conversation

@senxd
Copy link
Contributor

@senxd senxd commented Feb 4, 2026

When approving/sending feedback, the default behavior is to show a full-page indicator. I have added an option in the settings to close the tab after submitting instead.

@flex-yj-kim
Copy link
Contributor

Looks great! Could you share some screenshots of this feature? It would be much easier to understand.

@senxd
Copy link
Contributor Author

senxd commented Feb 4, 2026

recording.mov

Here is a video. By default, it is toggled off, and nothing is changed. When enabled, it closes the tab once you approve/send feedback. It just helps with tab clutter as I close it regardless.

@backnotprop
Copy link
Owner

Big feature. Taking a look.

I just got back from my only vacation this year and will get these PRs going.

@backnotprop
Copy link
Owner

Code review

Found 1 issue:

  1. window.close() will be blocked by browser security in most cases. Plannotator opens tabs via system commands (open, xdg-open, start), not window.open(), so browsers block the close attempt. All 4 call sites have no fallback UI or indication to the user when the close fails -- the tab just stays open silently. This limitation was previously documented in Issue #41. Consider adding a fallback (e.g., showing the existing success overlay when window.close() doesn't work).

});
if (getAutoClose()) {
window.close();
}
setSubmitted('approved');

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@backnotprop
Copy link
Owner

Ignore that review. I'm not seeing an issue with newer browsers.

…settings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@backnotprop backnotprop merged commit 1d2948b into backnotprop:main Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants