Skip to content

remote: support explicit local override for PLANNOTATOR_REMOTE#481

Merged
backnotprop merged 1 commit intobacknotprop:mainfrom
foxytanuki:fix/480-remote-tristate
Apr 4, 2026
Merged

remote: support explicit local override for PLANNOTATOR_REMOTE#481
backnotprop merged 1 commit intobacknotprop:mainfrom
foxytanuki:fix/480-remote-tristate

Conversation

@foxytanuki
Copy link
Copy Markdown
Contributor

Closes #480

Summary

PLANNOTATOR_REMOTE currently only gives explicit meaning to the remote side, so false / 0 still fall through to SSH auto-detection.

This PR aligns the runtime and docs around explicit tri-state semantics:

  • 1 / true forces remote mode
  • 0 / false forces local mode
  • unset keeps the existing SSH-based auto-detection path

It also updates both Bun and Pi runtimes, adds regression coverage, and refreshes the related docs/readmes to match the actual behavior.

Notes

  • Explicit local override now bypasses SSH_TTY / SSH_CONNECTION
  • Unset PLANNOTATOR_REMOTE still preserves the legacy SSH auto-detect behavior
  • Remote browser handling docs were updated to reflect that behavior depends on the configured browser handler and environment

Testing

  • bun test packages/server/remote.test.ts packages/server/browser.test.ts apps/pi-extension/server/network.test.ts

@foxytanuki foxytanuki marked this pull request as ready for review April 4, 2026 05:54
Copy link
Copy Markdown
Owner

@backnotprop backnotprop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from Plannotator

@backnotprop backnotprop merged commit 2636454 into backnotprop:main Apr 4, 2026
5 checks passed
@foxytanuki foxytanuki deleted the fix/480-remote-tristate branch April 5, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify PLANNOTATOR_REMOTE=false semantics or add explicit remote disable

2 participants