fix(review): gutter hover button + bump @pierre/diffs to 1.1.20#630
Merged
backnotprop merged 1 commit intomainfrom Apr 30, 2026
Merged
fix(review): gutter hover button + bump @pierre/diffs to 1.1.20#630backnotprop merged 1 commit intomainfrom
backnotprop merged 1 commit intomainfrom
Conversation
… to 1.1.20 The renderHoverUtility callback was gating on getHoveredLine() during React render, but Pierre updates hover state imperatively — so the button was permanently null. Always render the button; call getHoveredLine() only in the click handler. Also aligned button sizing/colors with Pierre's own [data-utility-button] spec. For provenance purposes, this commit was AI assisted.
Owner
Author
|
Note for follow-up work: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderHoverUtilitywas callinggetHoveredLine()during React render to decide whether to show the button. But Pierre updates hover state imperatively via pointer events (no React re-render), so the button was permanently null. Now the button always renders;getHoveredLine()is only called at click time.[data-utility-button]spec:1lhsizing,--diffs-modified-basebackground, correct margin/padding. Previously used hardcoded1.25remandoklch()purple that didn't match Pierre's theme.@pierre/diffsfrom 1.1.12 → 1.1.20 — picks up split-view scroll fix, WorkerPool race condition fix, hydration fixes, CSS refactoring, and empty-file-as-deleted fix.Test plan
+button should appear on every line hover+button — comment toolbar should open for that line