fix(review): hide-whitespace matches GitHub's git diff -w#635
Merged
backnotprop merged 1 commit intomainfrom Apr 30, 2026
Merged
fix(review): hide-whitespace matches GitHub's git diff -w#635backnotprop merged 1 commit intomainfrom
backnotprop merged 1 commit intomainfrom
Conversation
… GitHub The diff library's ignoreWhitespace only trims leading/trailing whitespace, so interior changes (alignment padding, extra spaces between tokens) still showed as diffs. Normalize all whitespace before diffing to match git diff -w. Also adds a real code change to the settings.ts demo so the file isn't fully collapsed when hide-whitespace is on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
difflibrary'signoreWhitespace), so interior whitespace changes like alignment padding (NODE_ENV: z.enum(...)→NODE_ENV: z.enum(...)) and extra spaces between tokens (from 'zod'→from 'zod') were still showing as diffs. Now normalizes all whitespace runs to a single space before diffing, matching GitHub's?w=1/git diff -wbehavior.pool.max: 5 → 10) to thesettings.tsdemo file so it's not fully collapsed when hide-whitespace is on — demonstrates the feature clearly.Test plan
bun run dev:review)src/config/settings.tsin the file treemax: ... ? 20 : 5→10change should remain