fix(ui): code file and linked doc resolution in annotate-last mode#647
Merged
backnotprop merged 2 commits intomainfrom May 1, 2026
Merged
fix(ui): code file and linked doc resolution in annotate-last mode#647backnotprop merged 2 commits intomainfrom
backnotprop merged 2 commits intomainfrom
Conversation
In annotate-last mode, imageBaseDir is set to "last-message" (a non-path string), which gets sent as the base query param to /api/doc and causes a 404. Guard both the code file popout and linked doc URL builders to skip non-path imageBaseDir values and fall back to projectRoot instead.
Sending base=projectRoot bypasses the isWithinProjectRoot check in /api/doc for code files (line 80) and skips containment entirely for markdown (lines 40-57). Fall back to undefined instead, which omits the base param and lets the server resolve paths against its own cwd with sandbox checks intact — matching plan mode behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imageBaseDiris set to"last-message"— a truthy non-path string that gets sent as thebasequery param to/api/doc, causing a 404imageBaseDirvalues and fall back toprojectRootTest plan
apps/pi-extension/plannotator-events.ts)