Skip to content

feat(review): add jj review workflows#675

Merged
backnotprop merged 11 commits intobacknotprop:mainfrom
graemefolk:jj-support
May 8, 2026
Merged

feat(review): add jj review workflows#675
backnotprop merged 11 commits intobacknotprop:mainfrom
graemefolk:jj-support

Conversation

@graemefolk
Copy link
Copy Markdown
Contributor

Summary

  • add JJ as a first-class VCS backend for local review flows across the hook server, OpenCode command path, and shared review-core types
  • move compare-target semantics into the VCS abstraction so the review server and UI stop branching on JJ-specific flags and instead consume provider-supplied picker metadata
  • extend the review UI and feedback/export flows to support JJ diff modes, compare-target selection, and JJ-specific copy and empty states

@backnotprop
Copy link
Copy Markdown
Owner

Sounds great

@madhusudancs
Copy link
Copy Markdown

Can we please merge this? I love plannotator. It's been a big productivity unlock for me. And same goes for jj. Having the ability to combine the two will have a compounding effect. Right now, I use plannotator for all planning work and fallback to Github PR UI for code reviews. Being able to do it locally would be highly valuable.

Not an expert in plannotator codebase, but I am happy to help in anyway possible to push this through. Let me know.

@backnotprop
Copy link
Copy Markdown
Owner

@madhusudancs pushing the review through now

@graemefolk
Copy link
Copy Markdown
Contributor Author

Changes look really clean, thanks for fixing it up!

@backnotprop
Copy link
Copy Markdown
Owner

Thanks, bear with me. Certain edge cases and things. Plus structuring for Pi users and introduction of another VCS after (git butler)

@backnotprop
Copy link
Copy Markdown
Owner

This will merge tonight though

@backnotprop backnotprop merged commit 69ef11b into backnotprop:main May 8, 2026
10 checks passed
@madhusudancs
Copy link
Copy Markdown

@backnotprop thank you so much!

@backnotprop
Copy link
Copy Markdown
Owner

Released in 0.19.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants