fix(review): resolve jj default target from trunk#686
Merged
backnotprop merged 1 commit intobacknotprop:mainfrom May 9, 2026
Merged
fix(review): resolve jj default target from trunk#686backnotprop merged 1 commit intobacknotprop:mainfrom
backnotprop merged 1 commit intobacknotprop:mainfrom
Conversation
Resolve the default JJ compare target from trunk() so review UI and diff behavior use the same concrete bookmark when JJ can identify one.
Owner
|
Thanks @graemefolk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update to resolve the default jj compare target from
trunk()to the concrete bookmark that jj reports, rather than iterating a hardcoded list of potentials.