Start daemon on install so hooks work immediately#806
Merged
Conversation
Install scripts now start the daemon in the background after placing the binary. This ensures improve-context and future pre-session hooks have a daemon to talk to from the first invocation. - install.sh: background start with >/dev/null 2>&1 & - install.ps1: Start-Process with -WindowStyle Hidden -ErrorAction SilentlyContinue - Mark backlog items #6 (smart session opening) and #14 (daemon on install) as DONE
On Windows the running exe is file-locked; on Unix the old daemon keeps serving stale code from memory. Now both installers stop any existing daemon before replacing the binary, then start a fresh one after.
Start-Process -Wait has no timeout. If the stop command hangs (antivirus, debugger), the installer freezes. Now uses -PassThru with WaitForExit(10s) and Kill() fallback so the installer always continues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
improve-contextand future pre-session hooks have a daemon to talk to from the first invocationChanges
scripts/install.sh—"$INSTALL_DIR/plannotator" daemon start >/dev/null 2>&1 &scripts/install.ps1—Start-Processwith-WindowStyle Hidden -ErrorAction SilentlyContinueTest plan
bun run typecheckpassesbun testpasses (1,331 tests)-ErrorAction SilentlyContinueto handle antivirus/SmartScreen locks